Fix issue with ':' in mustache block quoted text #3988
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
such as style attribute assignments and attribute values
dbolack-ab
added
tweak
|
A very similar regex issue occurs with Hmm .. testing the regex in regex101 suggests it should work already, except it doesn't. |
Yeah, I didn't test those because I wasn't trying to solve for them. :) Let me see what I can find. |
Allows users to not need '\"\'' and '\'\"' to wrap values. double quotes may be used alone. Nested quotes is still supported and translated to single quotes in assignment.
5 tasks
|
this fix is in good place, just tested and it works, should go for a full testing to make sure we don't break anything else |
|
Consider this will have to merge with #4004 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with CSS Attribute assignment strings containing
:in mustache blocksDescription
This updates the regex to permit
:in the right side of a CSS attribute/property or HTML attribute assignment.Related Issues or Discussions
QA Instructions, Screenshots, Recordings
Should now generate
Instead of
etc. Should work for all four mustache situations.
Reviewer Checklist
*Reviewers, refer to this list when testing features, or suggest new items *