Report observer status in cluster replicas for streams and consumers #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependent on nats.go and jsm.go PRs before the |
ripienaar
requested changes
Sep 26, 2023
| @@ -2,9 +2,14 @@ module github.com/nats-io/natscli | |||
|
|
|||
| go 1.20 | |||
|
|
|||
| replace github.com/nats-io/jsm.go => github.com/nats-io/jsm.go v0.1.1-0.20230926090317-6fb84b8ef01d | |||
There was a problem hiding this comment.
I'd rather not have these and instead update the dependency to point to the commit.
I keep forgetting about these and then do a release with them in which then end up failing go install installation method - happened when I did 0.1.0 and then had to do 0.1.1.
So hoping to avoid this mistake all together if I can :)
There was a problem hiding this comment.
Yep, these will be removed as commented above but for now it's just so that CI does the right thing while in draft state.
There was a problem hiding this comment.
Oh, sorry, I missed the comment you left there :)
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/observers
branch
from
2c433d3
to
5e2c2a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support nats-io/nats-server#4582.
Signed-off-by: Neil Twigg [email protected]