Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of the futures crate #935

Closed
wants to merge 2 commits into from

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Apr 25, 2023

Removes usage of futures macros. Considering this crate is very much married to the tokio ecosystem, it didn't make sense to also sometimes use the futures version of things. tokio::select was already being used somewhere else

@caspervonb
Copy link
Collaborator

I'm inclined to go the other direction, prefer futures crate over tokio, prefer std over futures.
Will discuss with Thomasz offline.

@caspervonb caspervonb requested review from caspervonb and Jarema and removed request for caspervonb April 25, 2023 14:33
@dodomorandi
Copy link
Contributor

Would you consider introducing the usage of futures-concurrency? Surely changing the abstraction is not a trivial task (especially for select! -> merge), but I think it could be worth considering the idea.

@caspervonb
Copy link
Collaborator

Would you consider introducing the usage of futures-concurrency? Surely changing the abstraction is not a trivial task (especially for select! -> merge), but I think it could be worth considering the idea.

Never outright against something, will look into it.

@paolobarbolini
Copy link
Contributor Author

What do we think about this? In the long term we may want to reduce usage of select, but for now wouldn't it be better to prefer tokio provided APIs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants