Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit nack method in message #1340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bvjebin
Copy link

@bvjebin bvjebin commented Nov 6, 2024

No description provided.

@Jarema
Copy link
Member

Jarema commented Nov 6, 2024

Hey.

Thanks for the PR!

However I do not think its good idea to add this method.
Especially that for consistency we would need to add all ACK types, plus nack with delay.

For the future, please discuss with us a proposed new API in an Issue :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants