Add ability to fetch stream subjects #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
Signed-off-by: Tomasz Pietrek <[email protected]>
|
|
caspervonb
reviewed
Oct 24, 2024
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| pub async fn info_with_subjects<F: AsRef<str>>( |
There was a problem hiding this comment.
Intend on adding overloads with deleted etc?
There was a problem hiding this comment.
yes. Will add to this PR.
There was a problem hiding this comment.
Ah, no.
I was wondering if we should have only the builder.
Those overloads look a bit silly at this point - with 3 different options, all valid choices.
| /// let mut stream = jetstream.get_stream("events").await?; | ||
| /// | ||
| /// let mut info = stream | ||
| /// .info_builder() |
There was a problem hiding this comment.
Feels any better? or same?
Suggested change
| /// .info_builder() | |
| /// .info_fetcher() |
There was a problem hiding this comment.
maybe sounds bit better, but at the same time - does not have notion that its a builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft solution that tries to find a sensible way to fetch subjects for from
stream info, which returns subjects with pagination nested under info.state.Signed-off-by: Tomasz Pietrek [email protected]