Remove useless use of Option around HeaderMap
#1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a bit of trivia as to why, before we used to send HMSG if headers were Some, even if they were empty. |
|
Boils down to this I think, Option signals semantics. Is an empty header map lighter than an empty header map? This conflicts with #1003 pretty heavily so, may merge but not before that is merged. |
paolobarbolini
force-pushed
the
useless-option-headermap
branch
from
8809b13
to
17dfb59
Compare
paolobarbolini
force-pushed
the
useless-option-headermap
branch
from
17dfb59
to
9b5d25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
HeaderMap::newdoesn't allocate, but instead creates an empty hashmap.Considering that code already has to check whether there really were any headers inside of the
HeaderMapwhen the variant isSome, theOptionaround it didn't make sense.