Add isort check to CICD #611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Merged
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
ff137
force-pushed
the
cicd/isort-check
branch
from
98853e5
to
3d93de9
Compare
caspervonb
reviewed
Oct 1, 2024
| @@ -31,6 +31,9 @@ jobs: | |||
| pipenv install --dev | |||
| bash ./scripts/install_nats.sh | |||
|
|
|||
| - name: Run isort check | |||
| run: pipenv run isort --check-only --diff . | |||
There was a problem hiding this comment.
Probably don't want to run this on every variant of the test matrix. Better if it was in check.yml (new workflow).
|
Including this in #608 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending #608
👷 Adds an isort check to the cicd.
➕ For that, I needed to add isort as a dev dependency to the Pipfile.
⬆️ Updated lock file (lots of version bumps! Last updated Jun 2023)
🔧 And, define
.isort.cfg, which includes the pyproject.toml[tool.isort]settings, because they weren't being picked up.