Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit PullSubscription config if config was passed in method. #506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chandr-andr
Copy link

Hello! Thank you for this awesome library.
I've found implicit behavior with the method pull_subscribe.

Problem:

After you shut down your worker with a pull-based subscription, the consumer continues to exist in Nats, and when you start your worker with the method pull_subscribe config doesn't change.
For example, a push-based subscription acts vice versa.

Solution:

So, I think it's better to edit the configuration every time you want to create a pull-based subscription. Because if you change your subscription configuration you expect that it will be changed in the nats.

If I missed something important, please, explain)

Signed-off-by: chandr-andr (Kiselev Aleksandr) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant