Edit PullSubscription config if config was passed in method. #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for this awesome library.
I've found implicit behavior with the method
pull_subscribe
.Problem:
After you shut down your worker with a
pull-based
subscription, the consumer continues to exist in Nats, and when you start your worker with the methodpull_subscribe
config doesn't change.For example, a
push-based
subscription acts vice versa.Solution:
So, I think it's better to edit the configuration every time you want to create a
pull-based
subscription. Because if you change your subscription configuration you expect that it will be changed in the nats.If I missed something important, please, explain)