Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of JsOptions timeout #953

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix use of JsOptions timeout #953

merged 1 commit into from
Aug 16, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Aug 15, 2023

When making requests from JetStream classes, the JetStreamOptions. There was use of the Connection options timeout instead in one place and this was fixed. Also, the default JetStreamOption timeout was resolved to the connection timeout if the JetStreamOption timeout was not explicitly set.

Copy link
Member

@ColinSullivan1 ColinSullivan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scottf scottf merged commit 154bcff into main Aug 16, 2023
1 check passed
@scottf scottf deleted the fix-js-options-timeout branch September 7, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants