Object Store use over leaf-hub domain #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Jun 17, 2024
| "jetstream {", | ||
| " domain: HUB", | ||
| " store_dir: " + tempJsStoreDir(), |
There was a problem hiding this comment.
specify a unique store dir for each server
scottf
commented
Jun 17, 2024
| @@ -225,7 +225,7 @@ private ObjectInfo validateObjectInfo(ObjectInfo oi, String bucket, String objec | |||
| } | |||
|
|
|||
| @SuppressWarnings("SameParameterValue") | |||
| private static Object[] getInput(int size) throws IOException { | |||
| private static Object[] getInput(int size) { | |||
There was a problem hiding this comment.
Exception isn't thrown
scottf
commented
Jun 17, 2024
| @@ -290,19 +290,21 @@ public static void runInJsHubLeaf(TwoServerTest twoServerTest) throws Exception | |||
| int leafPort = NatsTestServer.nextPort(); | |||
|
|
|||
| String[] hubInserts = new String[] { | |||
| "server_name: HUB", | |||
| "server_name: " + HUB_DOMAIN, | |||
scottf
commented
Jun 17, 2024
| "jetstream {", | ||
| " domain: LEAF", | ||
| " store_dir: " + tempJsStoreDir(), | ||
| " domain: " + LEAF_DOMAIN, |
There was a problem hiding this comment.
use the constant and store dir
scottf
commented
Jun 17, 2024
| String path3 = Files.createTempDirectory(variant()).toString().replace("\\", "\\\\"); | ||
| String path1 = tempJsStoreDir(); | ||
| String path2 = tempJsStoreDir(); | ||
| String path3 = tempJsStoreDir(); |
There was a problem hiding this comment.
refactored since I made a function
scottf
commented
Jun 17, 2024
| @@ -232,8 +232,7 @@ public ObjectInfo get(String objectName, OutputStream out) throws IOException, J | |||
| out.write(data); | |||
| } | |||
| else { | |||
|
|
|||
| JetStreamSubscription sub = js.subscribe(pubSubChunkSubject(oi.getNuid()), | |||
| JetStreamSubscription sub = js.subscribe(rawChunkSubject(oi.getNuid()), | |||
There was a problem hiding this comment.
This was the fix/bug.
There was a problem hiding this comment.
is it only problematic to use the pubSubChunkSubject on gets or does it cause problems everywhere? I ask because I had issues with puts and deletes on the HUB object store from the leaf as well. Maybe you could try deleting and putting a file from the leaf in your handy unit test below and see what happens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.