Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force Reconnect improvement
Execute
forceClose
with an executor task insideforceReconnect
. This prevents the force reconnect behavior from being blocked if close blocks.SocketDataPortWithWriteTimeout tuning
In the SocketDataPortWithWriteTimeout implementation of the timeout watcher task:
forceReconnect
directly instead of running it on an executor task thread. It's already running on an executor task thread because that's where the watcher runs.Socket SO LINGER
Added an
Options.socketSoLinger(int socketSoLinger)
for the user to set the underlyingsocket.setSoLinger()
. This will be used in normal close operations. If aforceClose
is requested, any option value supplied will be overridden withsetSoLinger(true, 0)
Force Close
Added a
forceClose()
to theDataPort
interface (with a default implementation that callsclose()
, to ensure interface backward compatibility)SocketDataPort
implementsforceClose()
forceReconnect
callsforceClose()
handleCommunicationIssue
callsforceClose