-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list_buckets function and tests to Object API #169
Conversation
Hey @jcreager thank you so much for opening the issue and then putting up a PR ❤️ 💛 💙 💚 💜 |
Right on, thanks @mmmries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only comment I left is something that would apply only for cases where Jetstream is hosting a large number of streams and we would potentially miss a bucket.
I think we can tackle that in a follow-up PR since it affects both of these functions and we'll probably want to handle them the same
Hey @mmmries just following up to see if you feel this is ok to merge. |
I'll get this released in a new patch version this evening. Thanks again for the contribution |
Thanks @mmmries! I'm happy I was able to make a contribution. |
Released as version 1.8.5 https://hex.pm/packages/gnat/1.8.5 |
This PR closes #168 and adds the ability to list Object bucket streams, replicating the nats CLI command
nats object ls
.Credit to @lsxliron as this PR is based off of their PR to add the
list_buckets
function to the KV API.