Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumer starting sequence with start time and multiple filters #6082

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Nov 6, 2024

fixes #6076

When starting by time option was used , a different codepath was taken when calculating starting sequence for the consumer. That codepath had off by one bug.

Signed-off-by: Tomasz Pietrek [email protected]

@Jarema Jarema requested a review from a team as a code owner November 6, 2024 22:06
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - racking up the off by 1 bugs!

@derekcollison derekcollison merged commit dd0bedd into main Nov 7, 2024
5 checks passed
@derekcollison derekcollison deleted the fix-consumer-with-start-seq branch November 7, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants