-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(v2.11) Stream ingest rate limiting #5796
Conversation
97e36ea
to
615ac9d
Compare
1384a38
to
bae368c
Compare
60a4b62
to
46a3a53
Compare
bae368c
to
0322966
Compare
46a3a53
to
2a19db6
Compare
0c70887
to
0ac8594
Compare
b37bd8b
to
22a1d66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general LGTM, a few small comments / questions.
22a1d66
to
bbb6576
Compare
1aba888
to
eef5abf
Compare
Signed-off-by: Neil Twigg <[email protected]>
eef5abf
to
4b2bea4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Built on top of #5575. Tries to prevent the stream
msgs
queue from becoming overwhelmed by core NATS publishes. In this case, where a reply subject is known, the sender will receive a 429 "Too Many Requests". Otherwise it's rate-logged.Two new configuration options are added to the JetStream block:
max_buffered_size
andmax_buffered_msgs
. If not configured, defaults are used.Signed-off-by: Neil Twigg [email protected]