Cherry-picks for 2.10.17-RC.7 #5572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <[email protected]>
#5082) This is a Test- and CI-only PR. No server changes. See also ConnectEverything/mqtt-test#2.
Otherwise long subjects could cause us to make the same reallocations on each call to `tokenizeSubjectIntoSlice` without reusing the newly sized underlying array for the next call. Signed-off-by: Neil Twigg <[email protected]>
…subject transform (#5574) In some cases a bad subject transform could still pass the validation test that is part of the config check when updating a stream config, and no error would be returned. Now return an error when trying to update a stream config with a source that has a bad subject transform that is not caught by the subject transform destination check in the stream config check. Improves #5571 --------- Signed-off-by: Jean-Noël Moyne <[email protected]>
…ing the session (#5575) MQTT s.clear(): do not wait for JS responses when disconnecting the session Related to #5471 Previously we were making `jsa.NewRequest` as it is needed when connecting a clean session. On disconnect, there is no reason to wait for the response (and tie up the MQTT read loop of the client). This should specifically help situations when a client app with many MQTT connections and QOS subscriptions disconnects suddenly, causing a flood of JSAPI deleteConsumer requests. Test: n/a, not sure how to instrument for it.
This improves our updating of the outdated fblks when calling into fs.numFilteredPending() Signed-off-by: Derek Collison <[email protected]> --------- Signed-off-by: Derek Collison <[email protected]>
Bug was that new wildcard matching code would not reverse start and stop, which is needed since we walk backwards. Since they were not flipped as soon as start != stop, it would not enter the loop condition, e.g. start:1, stop:2 fails start >= stop. Signed-off-by: Derek Collison <[email protected]>
Removed leaf-node related `TestXMQTTRetained...` test cases, they were too flaky.
Should provide some deduplication of long subjects in memory when message blocks are loaded in. Signed-off-by: Neil Twigg <[email protected]> --------- Signed-off-by: Neil Twigg <[email protected]> Signed-off-by: Derek Collison <[email protected]> Co-authored-by: Derek Collison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
isMatchin filestore/memstore #5573fss#5559Signed-off-by: Neil Twigg [email protected]