[IMPROVED] Consumer delete time on interest policy streams with a large number of messages. #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rge number of messages. When we delete a consumer we need to simulate acking all messages from the ackfloor to the last sequence in the stream. If the consumer is new and only consumed and acked and few messages, or none, this could be costly and cause operational pauses for the parent stream. If the number of sequences we would need to process is obver a threshold we will let the checkInterestState() do the cleanup in a separate Go routine. Signed-off-by: Derek Collison <[email protected]>
Jarema
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we delete a consumer we need to simulate acking all messages from the ackfloor to the last sequence in the stream. If the consumer is new and only consumed and acked and few messages, or none, this could be costly and cause operational pauses for the parent stream.
If the number of sequences we would need to process is obver a threshold we will let the checkInterestState() do the cleanup in a separate Go routine.
Signed-off-by: Derek Collison [email protected]