Fix linear scan in LoadNextMsg with partial per-subject info state
#5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
changed the title
numFilteredPending with partial per-subject info stateLoadNextMsgs with partial per-subject info state
neilalexander
force-pushed
the
nfp-linear-scan
branch
from
1d34284
to
a5a688b
Compare
neilalexander
changed the title
LoadNextMsgs with partial per-subject info stateLoadNextMsg with partial per-subject info state
If the per-subject info didn't have a correct first block (which is possible as it is populated lazily), then `LoadNextMsg` could end up making a very expensive call through to `numFilteredPending` which would do a linear scan of potentially many blocks. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
nfp-linear-scan
branch
from
a5a688b
to
4396a5d
Compare
Merged
derekcollison
added a commit
that referenced
this pull request
Jun 14, 2024
wallyqs
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the per-subject info didn't have a correct first block (which is possible as it is populated lazily), then
LoadNextMsgcould end up making a very expensive call through tonumFilteredPendingwhich would do a linear scan of potentially many blocks.Signed-off-by: Neil Twigg [email protected]