Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fix and new feature. #270

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

some fix and new feature. #270

wants to merge 61 commits into from

Conversation

Jiangshan00001
Copy link

the changelog:

  1. add memory support for sapi.
    eg:
b = BytesIO()
engine.save_to_file('i am Hello World', b)
engine.runAndWait()

  1. fix VoiceAge key error

  2. fix for sapi save_to_file when it run on machine without outputsream device.

Hunta88 and others added 30 commits November 20, 2021 22:25
@Hunta88
Fix typo in Documentation
c4ad34a 
under describe:: finished-utterance
"...have the folowing signature." was changed to "...have the following signature."
@Jiangshan00001
add memory support for sapi
0f7a7eb
@Jiangshan00001
Update README.md
28e2a01
@Jiangshan00001
fix VoiceAge not found error
9670acc 
fix `VoiceAge` not found error
@Jiangshan00001
Update README.md
f63e206
@Jiangshan00001
fix memory can not do more than once error
c3627b1
@Jiangshan00001
Merge pull request #1 from Hunta88/master
faa260e 
Fix typo in Documentation
@Jiangshan00001
fix for sapi save_to_file when it run on machine without outputsream …
86c2570 
…device.

fix for sapi save_to_file when it run on machine without outputsream device.
@Jiangshan00001
fix for sapi save_to_file when it run on machine without outputsream …
fc0623a 
…device.

fix for sapi save_to_file when it run on machine without outputsream device.
@Jiangshan00001
Merge branch 'master' of https://github.com/Jiangshan00001/pyttsx4
9c24a16
@Jiangshan00001
Update README.md
d94e1c5
@Jiangshan00001
Update issue templates
ec566df
@Jiangshan00001
add save_to_file BytesIO support to espeak
85c1f20
@Jiangshan00001
nsss save_to_file no content error fix
e76d898 
nsss save_to_file no content error fix
@Jiangshan00001
Update README.md
916018a
@Jiangshan00001
Update README.md
966f72e
@Jiangshan00001
Update README.md
3fe1bd4
@Jiangshan00001
add pitch support for sapi5
d4729a1
@Jiangshan00001
fix sapi5 pitch support
b468521
@Jiangshan00001
update readme
5339f66
@Jiangshan00001
remove six.py and use six package instead
1f724bb 
remove six.py and use six package instead
@matt-oakes
Import super from objc to fix AttributeError
c17956f
@Jiangshan00001
Merge pull request #4 from matt-oakes/objc-super
80f6f26 
Import super from objc to fix AttributeError
@Jiangshan00001
add 3.0.10 version
b448cbe
@Jiangshan00001
Create python-macos-test.yml
8ba678e
@Jiangshan00001
test macos using github actions
4c21074
@Jiangshan00001
add save_to_file test
5563a8f
@Jiangshan00001
Update pyttsx4_test.py
2602666
@Jiangshan00001
Update pyttsx4_test.py
afd10b4
@Jiangshan00001
Update python-macos-test.yml
c3c192d
skibblenybbles and others added 26 commits May 22, 2023 09:40
@skibblenybbles
Resolves nateshmbhat#142 for save_to_file() by managing driver proxy …
a83dd35 
…state similarly to say().
@Jiangshan00001
add coqui_ai_tts support
c6de55a
@Jiangshan00001
Update setup.py
22c9963
@Jiangshan00001
Create test2.wav
743c5a2
@Jiangshan00001
Update README.md
db5f249
@Jiangshan00001
Update README.md
f18dfc7
@Jiangshan00001
Update README.md
4cb28cd
@Jiangshan00001
Merge branch 'master' of https://github.com/Jiangshan00001/pyttsx4
1619126
@ekalosak
fixed language property for voice
ad7abe1
@Jiangshan00001
Merge pull request #7 from ekalosak/master
332215e 
fixed language property for voice
@Jiangshan00001
Merge branch 'pr/8'
3f0191c
@Jiangshan00001
3.0.13
4f01a6c 
revert an fix for save_to_file empty file os macos
@Jiangshan00001
fix req file
fe06523
@Jiangshan00001
Update requirements.txt
5639c2b
@Jiangshan00001
fix test file
ef0ac3d
@Jiangshan00001
add call to finish to avoid dead locks of nsss
c08c1e0
@Jiangshan00001
Update README.md
8ecd416
@Jiangshan00001
add voice cloning test
8d614d8
@Jiangshan00001
pyttsx4 say test for macos
b9b71d8
@Jiangshan00001
new version 3.0.14
d2b90be 
change nsss say function in order to avoid a callback bug.
@Jiangshan00001
add debug version of nsss
5de1a0e
@Jiangshan00001
Update nsss.py
6a87773
@Jiangshan00001
debug for nsss
7e01727
@Jiangshan00001
switch to release version
3a2784d
@Jiangshan00001
fix espeak & nsss engine error
d8aeb3a
@Jiangshan00001
macos new objc test
7712755
@nateshmbhat
Copy link
Owner

been away for quite some time now. can you please see if you can spend some time to resolve the merge conflicts ?

@willwade
Copy link
Collaborator

@nateshmbhat its not going to merge at all as its really referring to pyttsx4. But that aside I think voiceAge error and save_to_file when it run on machine without outputsream device is now fixed.

Im super intrigued about the memory support idea. Really @Jiangshan00001 was just wanting bytes back. I'll happily do a PR on this bit alone..

  • Do we want it streaming or only on completion?
  • Can you imagine a need for callbacks?

i.e. do we save_to_bytestream (like save to file) or do we save_to_bytestream and allow connect to work with this?

@willwade willwade mentioned this pull request Sep 27, 2024
Open
@willwade willwade mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Jiangshan00001 @nateshmbhat @willwade @Hunta88 @matt-oakes @skibblenybbles @ekalosak