Skip to content

Commit

Permalink
1811 dont override users cc and cpp env for data products (#1819)
Browse files Browse the repository at this point in the history
* Don't override the CC and C++ environment variables

Fixes an issue where some makefiles override the user's CC and C++
environment variables.

* Restore test makefiles

* Test to change from CC = cc to CC = gcc for only needed files.

* Restore the whitespaces to their original state before the update in order to show the necessary file changes for the PR.

---------

Co-authored-by: Nino Tarantino <[email protected]>
  • Loading branch information
hchen99 and ninotarantino authored Jan 7, 2025
1 parent 80063bf commit 0695391
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion trick_source/data_products/DPX/APPS/FXPLOT/makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
include ${TRICK_HOME}/share/trick/makefiles/Makefile.common

RM = rm -rf
CC = cc
CC = gcc
CPP = c++

DPX_DIR = ../..
Expand Down
2 changes: 1 addition & 1 deletion trick_source/data_products/DPX/APPS/GXPLOT/makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
include ${TRICK_HOME}/share/trick/makefiles/Makefile.common

RM = rm -rf
CC = cc
CC = gcc
CPP = c++

DPX_DIR = ../..
Expand Down
2 changes: 1 addition & 1 deletion trick_source/data_products/DPX/DPC/makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
include ${TRICK_HOME}/share/trick/makefiles/Makefile.common

RM = rm -rf
CC = cc
CC = gcc
CPP = c++

DPX_DIR = ..
Expand Down
2 changes: 1 addition & 1 deletion trick_source/data_products/DPX/DPM/makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
include ${TRICK_HOME}/share/trick/makefiles/Makefile.common

RM = rm -rf
CC = cc
CC = gcc
CPP = c++

DPX_DIR = ..
Expand Down
2 changes: 1 addition & 1 deletion trick_source/data_products/EQParse/makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

include ${TRICK_HOME}/share/trick/makefiles/Makefile.common

CC = cc
CC = gcc

OBJ_DIR = object_${TRICK_HOST_CPU}
LIBDIR = ../lib_${TRICK_HOST_CPU}
Expand Down
2 changes: 1 addition & 1 deletion trick_source/data_products/units/makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

include ${TRICK_HOME}/share/trick/makefiles/Makefile.common

CC = cc
CC = gcc
CPP = c++

ifndef TRICK_HOST_CPU
Expand Down
2 changes: 1 addition & 1 deletion trick_source/sim_services/DataTypes/makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

RM = rm -rf
CC = cc
CC = gcc
CPP = c++


Expand Down
2 changes: 1 addition & 1 deletion trick_source/trick_utils/SAIntegrator/makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

RM = rm -rf
CC = cc
CC = gcc
CPP = c++

CFLAGS = -g -Wall -std=c++11 ${TRICK_CXXFLAGS}
Expand Down
2 changes: 1 addition & 1 deletion trick_source/web/CivetServer/makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
include ${TRICK_HOME}/share/trick/makefiles/Makefile.common

RM = rm -rf
CC = cc
CC = gcc
CPP = c++
CURL = curl
MV = mv
Expand Down

0 comments on commit 0695391

Please sign in to comment.