-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workers for webpack 5 #7722
base: master
Are you sure you want to change the base?
Conversation
…use ES6 syntax.
…dWorker initialization in CouchObjectProvider.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7722 +/- ##
==========================================
+ Coverage 56.87% 60.56% +3.69%
==========================================
Files 673 431 -242
Lines 27182 13513 -13669
Branches 2635 0 -2635
==========================================
- Hits 15459 8184 -7275
+ Misses 11392 5329 -6063
+ Partials 331 0 -331
... and 374 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
sharedWorker = new SharedWorker( | ||
sharedWorkerURL, | ||
/* webpackChunkName: "couchDBChangesFeed" */ new URL( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff!
@ozyx if you need anything from webpack side of things for this to land, let me know! :) |
Closes
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist