Update workers for webpack 5 #7722
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use ES6 syntax.
…dWorker initialization in CouchObjectProvider.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.onmessage = function handleMessage(event) { | ||
| var message = event.data; | ||
| var handler = handlers[message.request]; | ||
| self.onmessage = (event) => { |
Check warning
Code scanning / CodeQL
Missing origin verification in `postMessage` handler Medium
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7722 +/- ##
==========================================
+ Coverage 56.87% 60.56% +3.69%
==========================================
Files 673 431 -242
Lines 27182 13513 -13669
Branches 2635 0 -2635
==========================================
- Hits 15459 8184 -7275
+ Misses 11392 5329 -6063
+ Partials 331 0 -331
... and 374 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| sharedWorker = new SharedWorker( | ||
| sharedWorkerURL, | ||
| /* webpackChunkName: "couchDBChangesFeed" */ new URL( |
|
@ozyx if you need anything from webpack side of things for this to land, let me know! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist