Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically generate asset urls #7705

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Apr 27, 2024

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.16%. Comparing base (37b2660) to head (0c6146f).

Files with missing lines Patch % Lines
example/imagery/plugin.js 83.33% 1 Missing ⚠️
src/plugins/themes/darkmatter.js 0.00% 1 Missing ⚠️
src/ui/layout/AboutDialog.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7705      +/-   ##
==========================================
- Coverage   62.48%   57.16%   -5.33%     
==========================================
  Files         433      676     +243     
  Lines       13583    27323   +13740     
  Branches        0     2673    +2673     
==========================================
+ Hits         8488    15618    +7130     
- Misses       5095    11369    +6274     
- Partials        0      336     +336     
Flag Coverage Δ
e2e-ci 62.42% <77.77%> (+0.02%) ⬆️
e2e-full 23.49% <22.22%> (+<0.01%) ⬆️
unit 49.33% <27.27%> (?)
Files with missing lines Coverage Δ
example/imagery/exampleImages.js 100.00% <100.00%> (ø)
src/plugins/themes/installTheme.js 90.00% <ø> (ø)
src/ui/layout/AppLogo.vue 28.57% <100.00%> (ø)
example/imagery/plugin.js 86.66% <83.33%> (+1.92%) ⬆️
src/plugins/themes/darkmatter.js 0.00% <0.00%> (ø)
src/ui/layout/AboutDialog.vue 0.00% <0.00%> (ø)

... and 370 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b2660...0c6146f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants