fix(overlay plot): legend updates correctly when removing element via remove action #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7531 +/- ##
==========================================
+ Coverage 55.22% 55.25% +0.03%
==========================================
Files 672 672
Lines 26969 26965 -4
Branches 2622 2622
==========================================
+ Hits 14893 14900 +7
+ Misses 11356 11344 -12
- Partials 720 721 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
commented
Feb 28, 2024
| @@ -165,7 +165,6 @@ export default { | |||
| this.registerListeners(this.config); | |||
| } | |||
| this.listenTo(this.config.legend, 'change:expandByDefault', this.changeExpandDefault, this); | |||
| this.initialize(); | |||
ozyx
commented
Feb 28, 2024
Comment on lines
+209
to
+211
| if (seriesIndexToRemove === -1) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
don't remove a seriesModel if we don't find one in the list
There was a problem hiding this comment.
haha, that ... makes sense
jvigliotta
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7530
Closes #7527
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist