Add quick:=true option for sim.launch #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f longer actions. - command_astrobee: Add final auto-move after stereo and pano actions to canonicalize attitude and get nav features. - command_astrobee: Add auto-move to berth approach point prior to docking to avoid failures
trey0
commented
Feb 20, 2024
|
|
||
|
|
||
| @dataclass | ||
| class SurveyManagerExecutor: |
There was a problem hiding this comment.
It may seem a bit weird to create this class with one method. My thought was it would be nice to eventually migrate all the action handlers to be methods here... that strikes me as cleaner than inlining their definitions in the conditional branches below as it's done now. But for the time being, to keep this diff reasonably small for review, I just migrated the move() method because it is now getting reused in a few places.
|
Looks good to me, but want Marina to take a look first. Btw, in the future, if there is just a small bug like fixing the exit codes, it's probably easiest if you just push the change to Marina's PR directly (and then make adding quick and such a separate one) |
marinagmoreira
added a commit
that referenced
this pull request
Feb 22, 2024
This reverts commit d0cc317.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sim.launch: Addquick:=trueargument, switching to short versions of longer actions.command_astrobee: Add final auto-move after stereo and pano actions to canonicalize attitude and get nav features.command_astrobee: Add auto-move to berth approach point prior to docking to avoid failures.Note: This PR branch has been rebased on top of Marina's PR, so her diffs unfortunately appear here as well... sorry if you are seeing those changes twice. Please submit any relevant comments on her PR.