HARMONY-1970: Fix bbox parsing for EDR cube route. #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-durbin
requested review from
ygliuvt,
indiejames and
vinnyinverso
and removed request for
ygliuvt
ygliuvt
reviewed
Jan 9, 2025
| expect(result).to.eql([10, 20, 30, 40]); | ||
| }); | ||
|
|
||
| it('parses 6-element bbox correctly', function () { |
ygliuvt
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Tested locally successfully.
An interesting observation is that the request URL in workflow ui becomes http://localhost:3000/ogc-api-edr/1.1.0/collections/C1233800302-EEDTEST/cube?bbox=-140&bbox=20&bbox=-50&bbox=60&granuleId=G1233800343-EEDTEST&crs=EPSG%3A31975&f=image%2Fpng&datetime=1975-01-02T00%3A00%3A00Z%2F2020-01-01T01%3A00%3A00Z¶meter-name=blue_var rather than the original comma separated string for bbox. I think it is ok as the EDR schema actually specified the bbox as an array of numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1970
Description
Fixes an issue with bbox parsing for the EDR cube route. I also updated versions of dependencies.
Local Test Steps
Verify the bounding box is now parsed correctly for this request: http://localhost:3000/ogc-api-edr/1.1.0/collections/C1233800302-EEDTEST/cube?bbox=-140,20,-50,60&granuleId=G1233800343-EEDTEST&crs=EPSG%3A31975&f=image%2Fpng&datetime=1975-01-02T00%3A00%3A00Z%2F2020-01-01T01%3A00%3A00Z¶meter-name=blue_var
Verify that an invalid bbox field returns a 400 error to the user:
http://localhost:3000/ogc-api-edr/1.1.0/collections/C1233800302-EEDTEST/cube?bbox=-140,20,-50&granuleId=G1233800343-EEDTEST&crs=EPSG%3A31975&f=image%2Fpng&datetime=1975-01-02T00%3A00%3A00Z%2F2020-01-01T01%3A00%3A00Z¶meter-name=blue_var
PR Acceptance Checklist