Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check spelling 0.0.24 #3051

Merged
merged 24 commits into from
Dec 17, 2024
Merged

Check spelling 0.0.24 #3051

merged 24 commits into from
Dec 17, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 26, 2024

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

  • Upgrades check-spelling to v0.0.24 (GitHub will start triggering various annoying warnings for older versions at some point in the near future)
  • Remove dead rtems5 link (the link checker was complaining)
  • a handful of spelling fixes based on newer heuristics in spell-check-this
  • harmonize the Checklist markdown tables (some of which had incorrect links)
  • a bunch of accessibility fixes based on:

Do not use (click) here links

For more information, see:

(?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\()

Rationale

Testing/Review Recommendations

Testing was performed inhttps://github.com/check-spelling-sandbox/fprime/actions/

Future Work

I might actually ship a v0.0.25 in the near future (but quite likely not before the deprecations trigger).

.github/actions/markdown-check/mlc-config.json Outdated Show resolved Hide resolved
.github/actions/spelling/advice.md Show resolved Hide resolved
.github/actions/spelling/candidate.patterns Show resolved Hide resolved
.github/actions/spelling/expect.txt Outdated Show resolved Hide resolved
.github/actions/spelling/expect.txt Show resolved Hide resolved
Svc/ActiveLogger/docs/sdd.md Show resolved Hide resolved
Svc/PolyDb/docs/sdd.md Show resolved Hide resolved
Utils/Hash/openssl/sha.h Show resolved Hide resolved
docs/UsersGuide/cmake/cmake-api.md Outdated Show resolved Hide resolved
Autocoders/Python/doc/ReadMe.txt Show resolved Hide resolved
@jsoref jsoref force-pushed the check-spelling-0.0.24 branch from 13a5b6a to e0d1084 Compare November 26, 2024 07:15
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @thomas-bc I am going to allow CI to run. Will this run afoul of the refactoring for an updated website?

@thomas-bc
Copy link
Collaborator

Yes we should hold on this one, merge #3036 before merging the current PR here

@jsoref jsoref force-pushed the check-spelling-0.0.24 branch from e0d1084 to 6f1bf0d Compare December 10, 2024 08:00
@jsoref jsoref force-pushed the check-spelling-0.0.24 branch from 6f1bf0d to 28f5841 Compare December 13, 2024 18:46
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref force-pushed the check-spelling-0.0.24 branch from 28f5841 to 59792b1 Compare December 15, 2024 14:59
@jsoref
Copy link
Contributor Author

jsoref commented Dec 16, 2024

@thomas-bc I've rebased...

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will run CI.

@LeStarch
Copy link
Collaborator

Clean CI run. Merging!

@LeStarch LeStarch merged commit 5be3b19 into nasa:devel Dec 17, 2024
36 checks passed
@jsoref jsoref deleted the check-spelling-0.0.24 branch December 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants