-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check spelling 0.0.24 #3051
Check spelling 0.0.24 #3051
Conversation
13a5b6a
to
e0d1084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @thomas-bc I am going to allow CI to run. Will this run afoul of the refactoring for an updated website?
Yes we should hold on this one, merge #3036 before merging the current PR here |
e0d1084
to
6f1bf0d
Compare
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
6f1bf0d
to
28f5841
Compare
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
28f5841
to
59792b1
Compare
@thomas-bc I've rebased... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will run CI.
Clean CI run. Merging! |
Change Description
Checklist
markdown tables (some of which had incorrect links)Do not use
(click) here
linksFor more information, see:
Rationale
Testing/Review Recommendations
Testing was performed inhttps://github.com/check-spelling-sandbox/fprime/actions/
Future Work
I might actually ship a v0.0.25 in the near future (but quite likely not before the deprecations trigger).