-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Validate Templates (#2387) #2990
base: devel
Are you sure you want to change the base?
Conversation
- Add validate_templates.yml and support expect scripts.
* Update CI to be 3 distinct steps and build each step.
988b809
to
6cf0fe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really neat! 🚀
One question: do we want to have this workflow run on the devel
state of fprime-bootstrap
and fprime-tools
?
This would allow us to validate that we are keeping bootstrap/tools in sync with the devel version of F Prime. It could match the process in the tutorials tests, see e.g.
fprime/.github/workflows/ext-build-hello-world.yml
Lines 18 to 22 in 0e4b4c2
get-branch: | |
name: "Get target branch" | |
uses: ./.github/workflows/reusable-get-pr-branch.yml | |
with: | |
target_repository: fprime-community/fprime-tutorial-hello-world |
This has been a pretty successful process for the tutorials so far.
ab3efa6
to
94456ed
Compare
* Update expect scripts to use regex where needed to match strings.
94456ed
to
a602944
Compare
* Update CI run condition to match other F Prime CI.
Released
|
Yes, they should. But we can't confirm that they actually do unless we check it in CI. I am suggesting we should do that, following the same pattern that we use on our tutorial repositories. e.g.
This validates that the latest Or am I missing your point? |
Change Description
A description of the changes contained in the PR.
Rationale
A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.
Testing/Review Recommendations
Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.
Future Work
Note any additional work that will be done relating to this issue.