Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logger in baremetal FatalHandler component implementation #2986

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

ethancheez
Copy link
Contributor


Change Description

Os::Log::log no longer exists after the OSAL changes. The baremetal FatalHandler still had Os::Log::log. I changed it to Fw::Logger::log

Rationale

Critical bug for baremetal (Arduino) implementation. This causes a build error.

@LeStarch
Copy link
Collaborator

Good catch @ethancheez! I looks like you might be migrating things to v3.5.0.....just as a note, I am reworking much of the baremetal stuff too. I'll push a branch so you can see what I am up to.

@LeStarch
Copy link
Collaborator

@ethancheez
Copy link
Contributor Author

Good catch @ethancheez! I looks like you might be migrating things to v3.5.0.....just as a note, I am reworking much of the baremetal stuff too. I'll push a branch so you can see what I am up to.

Got it. Maybe I should've asked you before I started tackling this on my end 😅.

I committed my work on an fprime-arduino branch

I've also done work to transition the fprime-tutorial-arduino-blinker and the cookiecutter.

Do you want to leverage my progress? Since I got an LedBlinker deployment up and running with v3.5.0.

Some naming schemes are a little different for some OSAL implementations between my branch and your branch.

@LeStarch
Copy link
Collaborator

@ethancheez I will try to get your branches, and my branches merged together today. That way we have the best of both. Then I will try and tag everything!

Thanks for looking into this!

@LeStarch LeStarch merged commit 0e4b4c2 into nasa:devel Oct 28, 2024
34 checks passed
@Meganbrentshandacrain
Copy link

Can anyone help me with what all this is reporting and coming and branch I'm trying to make money from home that's what led me to github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants