EVR output: we print 6 digits worth of microseconds #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a pernicious behavior where EVR timestamps lie about their
sub-second values. I have this test program:
#include <stdio.h>
#include <inttypes.h>
void main(void)
{
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 1234);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12356);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123456);
}
It produces this output:
01:02:03.012
01:02:03.123
01:02:03.1234
01:02:03.12356
01:02:03.123456
so prior to this patch, if we were 1 hour, 2 minutes, 3 seconds, 123
microseconds past midnight, this was printed as "01:02:03.123" instead of
"01:02:03.000123". Any reasonable human looking at "01:02:03.123" would see a
value of "123000" microseconds.
|
@thomas-bc @timcanham would either of you review this change too? |
|
The check timed out. I have no reason to believe this would affect code QL as the change is a single digit. |
thomas-bc
pushed a commit
that referenced
this pull request
Aug 4, 2023
This avoids a pernicious behavior where EVR timestamps lie about their
sub-second values. I have this test program:
#include <stdio.h>
#include <inttypes.h>
void main(void)
{
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 1234);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12356);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123456);
}
It produces this output:
01:02:03.012
01:02:03.123
01:02:03.1234
01:02:03.12356
01:02:03.123456
so prior to this patch, if we were 1 hour, 2 minutes, 3 seconds, 123
microseconds past midnight, this was printed as "01:02:03.123" instead of
"01:02:03.000123". Any reasonable human looking at "01:02:03.123" would see a
value of "123000" microseconds.
Co-authored-by: Dima Kogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a pernicious behavior where EVR timestamps lie about their
sub-second values. I have this test program:
#include <stdio.h>
#include <inttypes.h>
void main(void)
{
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 1234);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 12356);
printf("%02d:%02d:%02d.%03" PRIu32 "\n", 1,2,3, 123456);
}
It produces this output:
01:02:03.012
01:02:03.123
01:02:03.1234
01:02:03.12356
01:02:03.123456
so prior to this patch, if we were 1 hour, 2 minutes, 3 seconds, 123
microseconds past midnight, this was printed as "01:02:03.123" instead of
"01:02:03.000123". Any reasonable human looking at "01:02:03.123" would see a
value of "123000" microseconds.