Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unmatched connections to matched ports #512

Merged
merged 76 commits into from
Oct 30, 2024
Merged

Conversation

jwest115
Copy link
Collaborator

@jwest115 jwest115 commented Sep 16, 2024

  • Added unmatched keyword
  • Updated parser to catch unmatched specifiers
  • Updated connection AST and semantics to include whether the connection is unmatched. Added error handling for the case where unmatched is specified on connections that do not have matched ports.
  • Updated automatic port numbering algorithm to consider unmatched connections
  • Added unit tests
  • Updated spec and user guide to include match constrained and unmatched concepts

Closes #249. Closes #525.

@jwest115 jwest115 marked this pull request as ready for review September 20, 2024 01:08
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Everything was functionally correct. I made some revisions for style, clarity, and efficiency.

@bocchino bocchino merged commit de869af into nasa:main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants