Fix a glitch in CI #498
Merged
Fix a glitch in CI #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 3.5 has broken the use of
scalaon the command line to run compiled Scala classes.scalanow invokes the Scala CLI, which has different behavior. See https://www.scala-lang.org/blog/2024/08/22/scala-3.5.0-released.html. The new way to run compiled Scala classes, if any, is not documented online. Scala 3.5.0 is so new that it is not yet available in MacPorts.For now, detect that Scala 3.5 is installed and disable the test in this case. This is OK for CI, because the checks done by this test are redundant with the checks done by the fpp-to-cpp tests. When the Scala docs and the distributions stabilize, we'll work out a better fix.