Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a glitch in CI #498

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Fix a glitch in CI #498

merged 7 commits into from
Aug 27, 2024

Conversation

bocchino
Copy link
Collaborator

@bocchino bocchino commented Aug 27, 2024

Scala 3.5 has broken the use of scala on the command line to run compiled Scala classes. scala now invokes the Scala CLI, which has different behavior. See https://www.scala-lang.org/blog/2024/08/22/scala-3.5.0-released.html. The new way to run compiled Scala classes, if any, is not documented online. Scala 3.5.0 is so new that it is not yet available in MacPorts.

For now, detect that Scala 3.5 is installed and disable the test in this case. This is OK for CI, because the checks done by this test are redundant with the checks done by the fpp-to-cpp tests. When the Scala docs and the distributions stabilize, we'll work out a better fix.

Avoid name clash that seems to have appeared with a recent
Scala version.
Work around changes in scala
Attempt to be compatible with Scala 3.5.0
@bocchino bocchino requested a review from LeStarch August 27, 2024 01:29
@bocchino bocchino merged commit d9634ad into main Aug 27, 2024
11 checks passed
@bocchino bocchino deleted the fix/ci branch August 27, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants