Fixing removing the nullptr from join calls #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but can we hold off on merging this until nasa/fprime#2672 is merged into devel? Otherwise the code generated by FPP won't compile except against that PR branch, which looks like it's still in draft status. |
|
I'm going to make this a draft PR for now. We can make this and nasa/fprime#2672 ready for review at the same time. |
|
@bocchino I agree, this can hang out until the other is merged. Note: that one was a draft PR, but is now in-review. I was just cleaning up the CI tests before de-drafting it. |
bocchino
approved these changes
May 22, 2024
There was a problem hiding this comment.
Looks good! Ready to merge once nasa/fprime#2672 (review) is merged.
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #424