Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10118: Update default paging functionality for CMR-STAC #363

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

dmistry1
Copy link
Collaborator

Overview

Adds a reasonable page size of 100 for collection results. Also remove the logic where STAC was getting all of collections for a given provider. This was causing performance issue when a provider had thousands of collections records. Now if a provider have a more than 100 collection, a next link will be provider where they can retrieve next set of results

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.59%. Comparing base (92565e4) to head (9a3c0ee).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   88.34%   88.59%   +0.24%     
==========================================
  Files          24       24              
  Lines        1167     1166       -1     
  Branches      258      257       -1     
==========================================
+ Hits         1031     1033       +2     
+ Misses        136      133       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/routes/catalog.ts Outdated Show resolved Hide resolved
src/__tests__/providerCatalog.spec.ts Outdated Show resolved Hide resolved
@dmistry1 dmistry1 merged commit 2a46736 into master Oct 18, 2024
5 checks passed
@dmistry1 dmistry1 deleted the CMR-10118 branch October 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants