CMR-10118: Fixes lint

nasa · Oct 17, 2024 · 1432e10 · 1432e10
1 parent 8528286
commit 1432e10
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 16 deletions.
diff --git a/serverless.dev.yml b/serverless.dev.yml
@@ -9,7 +9,7 @@ provider:
     CMR_LB_URL: "https://cmr.sit.earthdata.nasa.gov"
     GRAPHQL_URL: "https://graphql.sit.earthdata.nasa.gov/api"
     STAC_VERSION: "1.0.0"
-    PAGE_SIZE: 100
+    PAGE_SIZE: "100"
 
 functions:
   stac:

diff --git a/src/__tests__/providerCatalog.spec.ts b/src/__tests__/providerCatalog.spec.ts
@@ -168,8 +168,8 @@ describe("GET /:provider", () => {
     describe("when there are more results available", () => {
       it("includes a 'next' link with the correct query parameters", async () => {
         sandbox
-        .stub(Provider, "getProviders")
-        .resolves([null, [{ "provider-id": "TEST", "short-name": "TEST" }]]);
+          .stub(Provider, "getProviders")
+          .resolves([null, [{ "provider-id": "TEST", "short-name": "TEST" }]]);
         const mockCollections = generateSTACCollections(100);
         sandbox.stub(Collections, "getCollectionIds").resolves({
           count: 100,
@@ -181,14 +181,14 @@ describe("GET /:provider", () => {
         });
 
         const { body: catalog } = await request(stacApp).get(`/stac/TEST`);
-  
-        console.log("🚀 ~ it.only ~ catalog:", catalog)
+
+        console.log("🚀 ~ it.only ~ catalog:", catalog);
         const nextLink = catalog.links.find((l: Link) => l.rel === "next");
         expect(nextLink).to.exist;
         expect(nextLink.rel).to.equal("next");
         expect(nextLink.type).to.equal("application/json");
         expect(nextLink.title).to.equal("Next page of results");
-  
+
         const nextUrl = new URL(nextLink.href);
         expect(nextUrl.pathname).to.equal("/stac/TEST");
       });
@@ -199,7 +199,7 @@ describe("GET /:provider", () => {
         sandbox
           .stub(Provider, "getProviders")
           .resolves([null, [{ "provider-id": "TEST", "short-name": "TEST" }]]);
-  
+
         const mockCollections = generateSTACCollections(10);
         sandbox.stub(Collections, "getCollectionIds").resolves({
           count: 10,
@@ -211,7 +211,7 @@ describe("GET /:provider", () => {
         });
 
         const { body: catalog } = await request(stacApp).get("/stac/TEST");
-  
+
         const nextLink = catalog.links.find((l: Link) => l.rel === "next");
         expect(nextLink).to.not.exist;
       });

diff --git a/src/domains/collections.ts b/src/domains/collections.ts
@@ -356,7 +356,7 @@ export const getAllCollectionIds = async (
   cursor: string | null;
   items: { id: string; title: string }[];
 }> => {
-  params.limit = CMR_QUERY_MAX
+  params.limit = CMR_QUERY_MAX;
 
   return await getCollectionIds(params, opts);
 };
diff --git a/src/domains/stac.ts b/src/domains/stac.ts
@@ -553,7 +553,7 @@ export const paginateQuery = async (
   opts: {
     headers?: IncomingHttpHeaders;
   },
-  handler: GraphQLHandler,
+  handler: GraphQLHandler
 ): Promise<GraphQLResults> => {
   const paginatedParams = { ...params };
 
@@ -589,7 +589,6 @@ export const paginateQuery = async (
     const { count, cursor, items } = data;
 
     return { items: items, count, cursor };
-
   } catch (err: unknown) {
     if (
       !(err instanceof Error) &&

diff --git a/src/routes/catalog.ts b/src/routes/catalog.ts
@@ -81,13 +81,13 @@ const generateSelfLinks = (req: Request, nextCursor?: string | null): Links => {
 
     links.push({
       rel: "next",
-      href:  `${stacRoot}${req.path}?${stringifyQuery(nextResultsQuery)}`,
+      href: `${stacRoot}${req.path}?${stringifyQuery(nextResultsQuery)}`,
       type: "application/json",
-      title: "Next page of results"
+      title: "Next page of results",
     });
   }
 
-  return links
+  return links;
 };
 
 const providerCollections = async (
@@ -97,7 +97,10 @@ const providerCollections = async (
 
   const cloudOnly = headers["cloud-stac"] === "true" ? { cloudHosted: true } : {};
 
-  const query2 = mergeMaybe({ provider: provider?.["provider-id"], cursor: query?.cursor }, { ...cloudOnly });
+  const query2 = mergeMaybe(
+    { provider: provider?.["provider-id"], cursor: query?.cursor },
+    { ...cloudOnly }
+  );
 
   try {
     const { items, cursor } = await getAllCollectionIds(query2, { headers });
@@ -120,7 +123,7 @@ export const providerCatalogHandler = async (req: Request, res: Response) => {
   const { self } = stacContext(req);
 
   const selfLinks = generateSelfLinks(req, cursor);
-  
+
   const childLinks = (collections ?? []).map(({ id, title }) => ({
     rel: "child",
     href: `${getBaseUrl(self)}/collections/${encodeURIComponent(id)}`,