-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docstrings to AIPlugIn #98
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 938 937 -1
Branches 129 129
=========================================
- Hits 938 937 -1 ☔ View full report in Codecov by Sentry. |
I don't have a strong preference for the comment style we use. If I had to pick, I would go with whatever the python libraries use. |
We have decided to follow numpydoc style: |
Hello, I've been browsing the other PR's and issues in the repository. I just wanted to note that since you all have decided on a docstring style to move forward with, most IDEs now have support for automatically generating docstring formats/templates for you to fill in. Essentially, all you will have to do is type In VSCode, you can use the autoDocstring extension, which has support for numpydoc. PyCharm already has automatic docstring templates builtin, and already supports numpydoc. |
Module has docstring (pylint) All methods have docstring (pytlint) Fixed high_level_data type Changed update args defaults to None removed use of [] and {} (pylint)
4430d0f
to
009b321
Compare
Python 3.8-3.10 need to import Any from typing AIPlugIn is deprecated, changed to AIPlugin
@dragonejt, thank you for the tool suggestions. As long as people follow the NumPy docstring formatting, they can use whatever tool they want to create them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for getting us on track for having a set style!
Just one small suggestion, otherwise good to merge.
174fc28
to
e5061d8
Compare
Here is an update for ai_plugin.py using Google style docstrings. Also using type annotations.
Is this the style we'd like to go forward with?
There are other style choices we could choose. i.e., NumPy, reST, or Epytext (others?)
Opinions?