Fixed -s (--save) feature #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from mkdir to makedirs with exist_ok set to True this allows any existing directories to be left alone this allows any non-exisiting directories to be build along the chain Removed prefixed '/' from save_path as it created double '//' Updated unit test
the-other-james
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Looks good, thanks for the fix!
I think we need to revisit if this is functionality we want to build in or if a plugin would be more appropriate (#91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from mkdir to makedirs with exist_ok set to True
Removed prefixed '/' from save_path creation as it made double '//'
Updated unit test