added a planning interface and renamed the DDL interface to learners. … #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Now we have planners and learners. Closes #50
There was a problem hiding this comment.
I think we want to get the 18_rebase branch merged in first just to make sure there aren't conflicts.
I would like to talk through the differences between the learners and planners since they seem very similar. I was also expecting to see how they are connected together, but I'm missing where that is. How does the learner inform the planner?
We need to start updating the Readme as we add new concepts (I should update it with the datasoure/adapter changes as well).
| Planners interface class for managing all planning-based AI components | ||
| """ | ||
| import importlib.util | ||
| import importlib.util |
There was a problem hiding this comment.
Oh, it's done in learners_interface.py as well
| return diagnoses | ||
|
|
||
|
|
||
|
|
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 22 +1
Lines 917 942 +25
Branches 130 131 +1
=========================================
+ Hits 917 942 +25
|
added 3 commits
October 5, 2023 21:31
…tion of planners versus learners
added 5 commits
October 6, 2023 16:42
…Now we have planners and learners. Closes #50
…tion of planners versus learners
asgibson
force-pushed
the
50-add-interface-to-planners
branch
from
7fc6c23
to
8b38584
Compare
asgibson
force-pushed
the
50-add-interface-to-planners
branch
from
16f36ce
to
64c2368
Compare
…Now we have planners and learners. Closes #50
…tion of planners versus learners
Removed unused test Changed str(MagicMock()) Removed extra line feeds
asgibson
force-pushed
the
50-add-interface-to-planners
branch
from
64c2368
to
2d84335
Compare
the-other-james
pushed a commit
to dennisafa/OnAIR
that referenced
this pull request
Feb 23, 2024
added a planning interface and renamed the DDL interface to learners. …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Now we have planners and learners. Closes #50