28 modularize data adapters #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evana13G
approved these changes
Sep 26, 2023
asgibson
approved these changes
Sep 26, 2023
the-other-james
added a commit
to dennisafa/OnAIR
that referenced
this pull request
Feb 23, 2024
28 modularize data adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
Data sources are now imported in the same way that plugins are: a file name is defined in the config file and imported with importlib.util.spec_from_file_location/module_from_spec.
Removed two unused config options.
Unit tests work on my local set. Also tested by moving the csv_parser.py out of the source tree and specifying the new location in the default .ini.