4 adapter parser refactor #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evana13G
approved these changes
Sep 25, 2023
the-other-james
added a commit
to dennisafa/OnAIR
that referenced
this pull request
Feb 23, 2024
4 adapter parser refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the concepts of DataSource and OnAirParser into a single OnAirDataSource that has functions allowing it to be used for processing files (like the csv_parser) or live telemetry (like SBN adapter or Redis adapter).
Headers are now processed from the meta data file which removes the need for live telemetry sources to define a "dummy" telemetry file just to initialize the headers.
The SBN adapter requires more rework to integrate back in (not due to these changes; the original implementation needs updating). Tracking in issue #42
Closes #4