Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for fixing testing of ast.parse #41

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Changes for fixing testing of ast.parse #41

merged 1 commit into from
Sep 18, 2023

Conversation

asgibson
Copy link
Contributor

@asgibson asgibson commented Sep 15, 2023 •
edited
Loading

ExecutionEngine

  • removed double import of ast
  • added ast_parse_eval function to handle ast.parse with mode eval
  • change usage of ast.parse to ast_parse_eval

Unit tests for ExecutionEngine

  • updated current parse_config tests to mock new function call
  • added test for ast_parse_eval
  • NOTE: this test has the same issue, but should never need to change

@asgibson
Changes for fixing testing of ast.parse
7e40cdf 
ExecutionEngine
  removed double import of ast
  added ast_parse_eval function to handle ast.parse with mode eval
  change usage of ast.parse to ast_parse_eval
Unit tests for ExecutionEngine
  updated current parse_config tests to mock new function call
  added test for ast_parse_eval
  NOTE: this test has the same issue, but should never need to change
@asgibson asgibson added the unit test Unit tests need fixed or added label Sep 15, 2023
@asgibson asgibson added this to the OnAIR 1.0 refactor milestone Sep 15, 2023
@asgibson asgibson self-assigned this Sep 15, 2023
@asgibson asgibson linked an issue Sep 15, 2023 that may be closed by this pull request
Extract ast.parse in execution_engine into own function #40
Closed
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #41 (7e40cdf) into main (0500300) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1102      1103    +1     
  Branches       144       144           
=========================================
+ Hits          1102      1103    +1
Files Changed Coverage Δ
onair/src/run_scripts/execution_engine.py 100.00% <100.00%> (ø)

the-other-james
the-other-james approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@the-other-james the-other-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking care of this.

Test all passed on my local setup.

@the-other-james the-other-james merged commit 96cc9d2 into main Sep 18, 2023
2 checks passed
@asgibson asgibson deleted the 40-extract-astparse-in-execution_engine-into-own-function branch September 18, 2023 18:00
the-other-james added a commit to dennisafa/OnAIR that referenced this pull request Feb 23, 2024
@the-other-james
Merge pull request nasa#41 from nasa/40-extract-astparse-in-execution…
9454f1a 
…_engine-into-own-function

Changes for fixing testing of ast.parse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-other-james the-other-james the-other-james approved these changes

Assignees

@asgibson asgibson

Labels
unit test Unit tests need fixed or added
Projects
None yet
Milestone
OnAIR 1.0 refactor
Development

Successfully merging this pull request may close these issues.

Extract ast.parse in execution_engine into own function
3 participants
@asgibson @codecov-commenter @the-other-james