25 make unit tests less brittle by dynamically naming mocker patch locations #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All patches using imported 'as' names Standardized import usage testing framework imports empty line tested code imports empty line, supporting code imports Removed any unused imports EXCEPT pytest pytest was left even if unused rationale: we don't want any test updates breaking due to it missing
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 1164 1164
Branches 155 155
=========================================
Hits 1164 1164 |
the-other-james
approved these changes
Aug 31, 2023
jlucas9
approved these changes
Aug 31, 2023
asgibson
deleted the
25-make-unit-tests-less-brittle-by-dynamically-naming-mockerpatch-locations
branch
the-other-james
pushed a commit
to dennisafa/OnAIR
that referenced
this pull request
Feb 23, 2024
…ass-aka-telemetry_test_suite-py-to-100' into 'main' Updates for testing telemetry_test_suite.py Closes nasa#29 See merge request cFS_lab/raisr_nos3/raisr-2.0!15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all tests to use the <import "as" named item>.__name__ in the mocker.patch calls.
Also standardized the imports in the test files.
Removed some unused files from the test directory (from the data dir, left the dir but no files).
Renamed test_brain.py to test_agent.py to reflect src code filename.
Renamed test_spacecraft to test_vehicle_rep to reflect src code filename.