Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18 add redis adapter #26

Closed
wants to merge 7 commits into from
Closed

18 add redis adapter #26

wants to merge 7 commits into from

Conversation

asgibson
Copy link
Contributor

No description provided.

@asgibson asgibson linked an issue Aug 17, 2023 that may be closed by this pull request
@asgibson asgibson self-assigned this Aug 17, 2023
@asgibson asgibson added the enhancement New feature or request label Aug 17, 2023
@asgibson asgibson marked this pull request as draft August 18, 2023 16:29
@asgibson asgibson force-pushed the 18-add-redis-adapter branch from 56be79c to aa765de Compare August 31, 2023 21:39
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #26 (e658188) into main (90c33f2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        23    +1     
  Lines          950      1003   +53     
  Branches       122       127    +5     
=========================================
+ Hits           950      1003   +53     
Files Changed Coverage Δ
onair/src/run_scripts/redis_adapter.py 100.00% <100.00%> (ø)

Still having some issues with couple of unit tests
message_listener untested
Added optional data argument
Added super call
Removed stray print of new data
Fixed print in message_listener
Replace class accessors with self
AdapterDataSource
  Removed print statements
  Overrode has_data to return instance value of new_data
test_redis_adapter
  Tested previously untested code
  Adjusted tests for changes to AdapterDataSource
@asgibson asgibson marked this pull request as ready for review October 6, 2023 19:14
Copy link
Contributor

@Evana13G Evana13G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im getting errors on running tests:

`python ./driver.py -t
conftest random seed = 1696876951.815276
================================= test session starts ==================================
platform darwin -- Python 3.9.5, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/egizzi/Documents/DSM/CODE/OPEN-SOURCE/OnAIR
plugins: mock-3.10.0
collected 342 items / 1 error

======================================== ERRORS ========================================
_______ ERROR collecting test/onair/src/ai_components/test_planners_interface.py _______
/Users/egizzi/miniconda3/lib/python3.9/site-packages/_pytest/python.py:618: in _importtestmodule
mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
/Users/egizzi/miniconda3/lib/python3.9/site-packages/_pytest/pathlib.py:533: in import_path
importlib.import_module(module_name)
/Users/egizzi/miniconda3/lib/python3.9/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
:1030: in _gcd_import
???
:1007: in _find_and_load
???
:986: in _find_and_load_unlocked
???
:680: in _load_unlocked
???
/Users/egizzi/miniconda3/lib/python3.9/site-packages/_pytest/assertion/rewrite.py:159: in exec_module
source_stat, co = _rewrite_test(fn, self.config)
/Users/egizzi/miniconda3/lib/python3.9/site-packages/_pytest/assertion/rewrite.py:337: in _rewrite_test
tree = ast.parse(source, filename=strfn)
/Users/egizzi/miniconda3/lib/python3.9/ast.py:50: in parse
return compile(source, filename, mode, flags,
E File "/Users/egizzi/Documents/DSM/CODE/OPEN-SOURCE/OnAIR/test/onair/src/ai_components/test_planners_interface.py", line 99
E <<<<<<< HEAD
E ^
E SyntaxError: invalid syntax
=============================== short test summary info ================================
ERROR test/onair/src/ai_components/test_planners_interface.py
!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!
=================================== 1 error in 1.15s =================`

@asgibson asgibson marked this pull request as draft October 10, 2023 14:14
@asgibson asgibson removed a link to an issue Oct 10, 2023
@asgibson asgibson linked an issue Oct 10, 2023 that may be closed by this pull request
@asgibson asgibson removed a link to an issue Oct 10, 2023
@asgibson
Copy link
Contributor Author

Superseded by #56

@asgibson asgibson closed this Oct 10, 2023
the-other-james pushed a commit to dennisafa/OnAIR that referenced this pull request Feb 23, 2024
…00-percent' into 'main'

Updates for testing ExecutionEngine

Closes nasa#26

See merge request cFS_lab/raisr_nos3/raisr-2.0!13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants