Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nasa/onair#9] Add CI Pipeline #20

Closed
wants to merge 10 commits into from
Closed

[nasa/onair#9] Add CI Pipeline #20

wants to merge 10 commits into from

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Aug 15, 2023

@asgibson did the heavy lifting here - I just pushed the first code coverage up and added fun badges to the readme.

@jlucas9 jlucas9 self-assigned this Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@4b7febb). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #20   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        25           
  Lines           ?      1164           
  Branches        ?       155           
========================================
  Hits            ?      1164           
  Misses          ?         0           
  Partials        ?         0

@the-other-james
Copy link
Contributor

Why did one of the checks fail? What's the difference between build (push) and build (pull_request)?

asgibson
asgibson approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@asgibson asgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@asgibson asgibson self-requested a review August 15, 2023 13:13
asgibson
asgibson requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@asgibson asgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Please add the code report section so that it may be viewed in the results.

@asgibson asgibson self-requested a review August 15, 2023 13:35
asgibson
asgibson requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@asgibson asgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing branch coverage and including test files in report.

putting --branch --source=onair into the pytest run should fix that (or --source=src,data_handling,utils if the current branch has not yet been rebased to main).

@jlucas9 jlucas9 requested a review from asgibson August 15, 2023 13:53
@jlucas9
Copy link
Contributor Author

jlucas9 commented Aug 15, 2023

Closing in favor of #21

@jlucas9 jlucas9 closed this Aug 15, 2023
@jlucas9 jlucas9 deleted the onair#9-Add-CI branch August 15, 2023 16:18
the-other-james added a commit to dennisafa/OnAIR that referenced this pull request Feb 23, 2024
@the-other-james
Merge branch '20-run-unit-tests-in-random-order' into 'main'
b77de0c 
Resolve "Run unit tests in random order"

Closes nasa#20

See merge request cFS_lab/raisr_nos3/raisr-2.0!11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evana13G Evana13G Awaiting requested review from Evana13G

@the-other-james the-other-james Awaiting requested review from the-other-james

@asgibson asgibson Awaiting requested review from asgibson

Assignees

@jlucas9 jlucas9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlucas9 @codecov-commenter @the-other-james @asgibson