Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#352] Updates to build in NOS3 RC 1.7.2; #384

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

jlucas9
Copy link
Collaborator

@jlucas9 jlucas9 commented Jan 10, 2025

Made some changes for NOS3 build. If running in NOS3 requires building the updated container (same branch name nos3#352) and changing the env.sh file to use it.

@jlucas9 jlucas9 self-assigned this Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (14ee573) to head (e23a6e5).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #384   +/-   ##
=======================================
  Coverage   75.97%   75.97%           
=======================================
  Files          81       81           
  Lines       22263    22263           
  Branches     1807     1807           
=======================================
  Hits        16914    16914           
  Misses       4707     4707           
  Partials      642      642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Donnie-Ice Donnie-Ice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end

@Donnie-Ice Donnie-Ice merged commit 911c886 into dev Jan 13, 2025
12 checks passed
@Donnie-Ice Donnie-Ice deleted the nos3#352 branch January 13, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants