-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-10173: Update UMM-C for Web Unitification round 2 #2184
base: master
Are you sure you want to change the base?
Conversation
umm-spec-lib/resources/json-schemas/collection/umm/v1.18.2/umm-c-json-schema.json
Outdated
Show resolved
Hide resolved
umm-spec-lib/resources/json-schemas/collection/umm/v1.18.2/umm-c-json-schema.json
Outdated
Show resolved
Hide resolved
@@ -19,6 +19,7 @@ | |||
[cmr.umm-spec.versioning :as umm-spec-versioning] | |||
[cmr.umm.dif.date-util :refer [parse-dif-end-date]])) | |||
|
|||
;; TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer support dif9, but we still have some collections in UAT and SIT that we have to delete. I am pretty sure we removed all DIF 9 records from production. Reading from DIF 9 to UMM should be good as is. We will have to make sure UMM-C to DIF 9 doesn't break, it if does then we need to fix the translations to what ever the dif 9 valid values are, we are not changing the dif 9 schema
@@ -30,6 +30,7 @@ | |||
[cmr.umm-spec.xml-to-umm-mappings.iso19115-2.tiling-system :as tiling] | |||
[cmr.umm-spec.versioning :as umm-spec-versioning])) | |||
|
|||
;; TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to add the mappings here.
"other" "Other"}) | ||
"other" "Other" | ||
"ispreviousversionof" "IsPreviousVersionOf" | ||
"isnewversionof" "IsNewVersionOf"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From UMM to ISO you used Capital letters, you should use the same case going back and forth. Also put in spaces for the IsPreviousVersionOf for the second value to read "Is Previous Version Of" same for IsNewVersionOf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is different from the slack conversation we had where we wanted to change this:
Add to the map on line 120 "ispreviousversionof" IsPreviousVersionOf" and "isnewversionof" "IsNewVersionOf". Without doing the coding myself I can't tell what the XML will look like.
Is this something we need to discuss further?
umm-spec-lib/test/cmr/umm_spec/test/migration/version/collection.clj
Outdated
Show resolved
Hide resolved
umm-spec-lib/test/cmr/umm_spec/test/migration/version/collection.clj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also give you sample files that you can test with on your local CMR.
THIS IS A DRAFT PR -- NOT READY FOR OFFICIAL REVIEW
Overview
What is the feature/fix?
Updating umm-c schema and translations
Adding 2 new enums values for AssociatedDOIs/Type:
IsPreviousVersionOf
IsNewVersionOf
Adding 3 new enums values for CollectionProgress:
PREPRINT, INREVIEW, and SUPERSEDED
Delete enum value for CollectionProgress:
NOT APPLICABLE
What is the Solution?
See above
What areas of the application does this impact?
Checklist