Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10173: Update UMM-C for Web Unitification round 2 #2184

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jmaeng72
Copy link
Contributor

@jmaeng72 jmaeng72 commented Oct 24, 2024

THIS IS A DRAFT PR -- NOT READY FOR OFFICIAL REVIEW

Overview

What is the feature/fix?

Updating umm-c schema and translations

Adding 2 new enums values for AssociatedDOIs/Type:
IsPreviousVersionOf
IsNewVersionOf

Adding 3 new enums values for CollectionProgress:
PREPRINT, INREVIEW, and SUPERSEDED

Delete enum value for CollectionProgress:
NOT APPLICABLE

What is the Solution?

See above

What areas of the application does this impact?

Checklist

  • I have updated/added unit and int tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors corrected
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@jmaeng72 jmaeng72 changed the title CMR-10173: Add copy of 1.18.1 as 1.18.2 CMR-10173: Update UMM-C for Web Unitification round 2 Oct 25, 2024
@jmaeng72 jmaeng72 marked this pull request as draft October 25, 2024 20:01
@jmaeng72 jmaeng72 self-assigned this Oct 25, 2024
@@ -19,6 +19,7 @@
[cmr.umm-spec.versioning :as umm-spec-versioning]
[cmr.umm.dif.date-util :refer [parse-dif-end-date]]))

;; TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer support dif9, but we still have some collections in UAT and SIT that we have to delete. I am pretty sure we removed all DIF 9 records from production. Reading from DIF 9 to UMM should be good as is. We will have to make sure UMM-C to DIF 9 doesn't break, it if does then we need to fix the translations to what ever the dif 9 valid values are, we are not changing the dif 9 schema

@@ -30,6 +30,7 @@
[cmr.umm-spec.xml-to-umm-mappings.iso19115-2.tiling-system :as tiling]
[cmr.umm-spec.versioning :as umm-spec-versioning]))

;; TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add the mappings here.

"other" "Other"})
"other" "Other"
"ispreviousversionof" "IsPreviousVersionOf"
"isnewversionof" "IsNewVersionOf"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From UMM to ISO you used Capital letters, you should use the same case going back and forth. Also put in spaces for the IsPreviousVersionOf for the second value to read "Is Previous Version Of" same for IsNewVersionOf

Copy link
Contributor Author

@jmaeng72 jmaeng72 Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from the slack conversation we had where we wanted to change this:

Add to the map on line 120 "ispreviousversionof" IsPreviousVersionOf" and "isnewversionof" "IsNewVersionOf". Without doing the coding myself I can't tell what the XML will look like.

Is this something we need to discuss further?

Copy link
Contributor

@eereiter eereiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also give you sample files that you can test with on your local CMR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants