-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Various NavMobile and NavJumpMenu fixes for EDU #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The horizontal overflow is fixed, but I'm still not seeing the on-page jump menu.
<span class="text-white font-bold text-xl pl-px">Education</span> | ||
<BaseLink | ||
class="text-white font-bold text-xl pl-px" | ||
to="/edubeta/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to update #660 for this after it's merged.
It's not intended to be visible on mobile. It's part of the mobile navigation. Would be nice to have it be visible but decided to wait on that as it's a bit more involved and not original spec. |
Ahhh, thanks for clarifying. |
Checklist
Description
Fixes regressions (some introduced in #656):
Changes:
overflow-x
to hidden on "Section" divs within the EDU Lesson template and EDU Student Project templateshidden
class to NavJumpMenu at smaller screen sizesEducation
inBaseLink
inNavMobile
Instructions to test
Tested in the following environments/browsers:
Operating System
Browser