Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Various NavMobile and NavJumpMenu fixes for EDU #666

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Oct 17, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Fixes regressions (some introduced in #656):

Changes:

  • sets overflow-x to hidden on "Section" divs within the EDU Lesson template and EDU Student Project templates
  • adds back hidden class to NavJumpMenu at smaller screen sizes
  • wraps Education in BaseLink in NavMobile

Instructions to test

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2024
@stephiescastle stephiescastle changed the title fix: NavJumpMenu visibility on mobile fix: Various NavMobile and NavJumpMenu fixes for EDU Oct 17, 2024
Copy link
Member

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The horizontal overflow is fixed, but I'm still not seeing the on-page jump menu.

<span class="text-white font-bold text-xl pl-px">Education</span>
<BaseLink
class="text-white font-bold text-xl pl-px"
to="/edubeta/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to update #660 for this after it's merged.

@stephiescastle
Copy link
Member Author

The horizontal overflow is fixed, but I'm still not seeing the on-page jump menu.

It's not intended to be visible on mobile. It's part of the mobile navigation. Would be nice to have it be visible but decided to wait on that as it's a bit more involved and not original spec.

@Scotchester
Copy link
Member

The horizontal overflow is fixed, but I'm still not seeing the on-page jump menu.

It's not intended to be visible on mobile. It's part of the mobile navigation. Would be nice to have it be visible but decided to wait on that as it's a bit more involved and not original spec.

Ahhh, thanks for clarifying.

@stephiescastle stephiescastle merged commit d64514a into main Oct 18, 2024
7 checks passed
@stephiescastle stephiescastle deleted the fix/mobile-jump-menu branch October 18, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants