Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU: adjusting height of accordion filter groups to match non-accordions #644

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Addresses feedback:

Changes:

  • modifies padding and margin around filter group accordions to match that of non-accordions

Instructions to test

  1. make-vue-storybook
  2. View http://localhost:6006/?path=/story/components-search-searchfiltergroup--sub-filters
  3. Inspect the filter items. Each should be a height of 32px.
    image

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the bug Something isn't working label Sep 30, 2024
Copy link
Member

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From playing with this in dev tools on the live site, I think there's still going to be a slight variation in the distance between checkboxes when accordions and non-accordions are mixed, but it should be negligible.

Tried to quickly figure out how to put together a combo story to test that but it wasn't immediately obvious to me how to do that. Good enough for now, regardless.

@stephiescastle stephiescastle merged commit ba84c40 into main Sep 30, 2024
6 checks passed
@stephiescastle stephiescastle deleted the fix/edu-resource-listing branch September 30, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants