Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: secondary nav offset, dayjs import in utils/filters.js #519

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Jul 29, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Supports https://github.com/nasa-jpl/www/issues/244

Instructions to test

  • difficult to test without using the www frontend app (requires publishing the npm package for general testing).
  • to test locally, you can follow these instructions to reference your local copy of explorer-1. Then:
  1. make backend
  2. make frontend
  3. make a content page and check "override secondary navigation"
  4. create child pages and check "show in menus"
  5. view the first content page you made on the frontend. You should see the secondary navigation stick to the top when scrolling. When scrolling back up, the main nav should appear, and the secondary nav should be offset just enough.

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle requested a review from jamesray July 29, 2024 18:59
@github-actions github-actions bot added the bug Something isn't working label Jul 29, 2024
@stephiescastle stephiescastle added patch Contains bug fixes or maintenance work and removed bug Something isn't working labels Jul 29, 2024
@stephiescastle stephiescastle merged commit 21ba7aa into main Jul 29, 2024
7 checks passed
@stephiescastle stephiescastle deleted the fix/244-secondary-nav-margin branch July 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants