Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: xfail case insensitive regex tests for cuDF #982

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

LiamConnors
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

These tests fail with a runtime error:

FAILED tests/expr_and_series/str/contains_test.py::test_contains[cudf_constructor] - RuntimeError: CUDF failure at:/opt/conda/conda-bld/work/cpp/src/strings/reg...

What I can find is that (?i) is likely not supported for cuDF. That's what it sounds like from rapidsai/cudf#5217 (the issue was opened for str.replace).

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiamConnors πŸ™ŒπŸΌ

Would it be worth adding a test for the case sensitive case to see if that passes as a follow up?

SpinCuteGIF

@FBruzzesi FBruzzesi merged commit 33f102e into narwhals-dev:main Sep 16, 2024
22 checks passed
@LiamConnors
Copy link
Member Author

Thanks @FBruzzesi! That's a good idea. I'll open a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants