Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assert with raise #980

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Replace assert with raise #980

merged 3 commits into from
Sep 15, 2024

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Sep 15, 2024

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@raisadz raisadz mentioned this pull request Sep 15, 2024
Merged
10 tasks
FBruzzesi
FBruzzesi reviewed Sep 15, 2024
View reviewed changes
Copy link
Member

@FBruzzesi FBruzzesi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time in this!
I have a nit suggestion, then we can merge

narwhals/_arrow/dataframe.py Outdated Show resolved Hide resolved
@FBruzzesi FBruzzesi merged commit c536c62 into narwhals-dev:main Sep 15, 2024
22 checks passed
@raisadz raisadz deleted the replace-assert-with-raise branch November 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBruzzesi FBruzzesi FBruzzesi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raisadz @FBruzzesi