-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Removed class, added polars to the table, str.head and str.tail are a⦠#1801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marvinl803 thanks for your contribution! I left a comment regarding the inclusion of polars in the tables :)
@@ -49,12 +49,15 @@ class Backend(NamedTuple): | |||
Backend(name="duckdb", module="_duckdb", type_=BackendType.LAZY), | |||
Backend(name="pandas-like", module="_pandas_like", type_=BackendType.EAGER), | |||
Backend(name="spark-like", module="_spark_like", type_=BackendType.LAZY), | |||
Backend(name="polars", module="_polars", type_=BackendType.EAGER), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you are referring to #1789 comment. However, this would not render as expected since our polars implementation mostly call polars methods dynamically. Since we follow a subset of the polars API, everything should be flagged as green for a potential polars column in each table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you are referring to #1789 comment. However, this would not render as expected since our polars implementation mostly call polars methods dynamically. Since we follow a subset of the polars API, everything should be flagged as green for a potential polars column in each table.
I've added a dummy column for Polars, as we discussed. Let me know if this approach works or if further adjustments are needed.
Thank you, I'll take a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton @marvinl803 π
What type of PR is this? (check all applicable)
Related issues
Expr.str.head
/Expr.str.tail
Β #1789Checklist
If you have comments or can explain your changes, please do so below
I removed the class column from the api-completeness table. Also added polars to the tables and marked Expr.str.head / Expr.str.tail as checked. If there is any issues or corrections needed please let me know, thank you!